Skip to content

Faiss: Remove duplicate NegativeDistanceComputer instances#571

Closed
alexanderguzhva wants to merge 1 commit intozilliztech:mainfrom
alexanderguzhva:code_cleanup_3
Closed

Faiss: Remove duplicate NegativeDistanceComputer instances#571
alexanderguzhva wants to merge 1 commit intozilliztech:mainfrom
alexanderguzhva:code_cleanup_3

Conversation

@alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented May 16, 2024

Corresponding faiss baseline PR: facebookresearch/faiss#3450
/kind improvement

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
@mergify
Copy link

mergify bot commented May 16, 2024

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@codecov
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (3c46f4c) to head (0e0aa57).
Report is 96 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #571       +/-   ##
=========================================
+ Coverage      0   70.04%   +70.04%     
=========================================
  Files         0       67       +67     
  Lines         0     4597     +4597     
=========================================
+ Hits          0     3220     +3220     
- Misses        0     1377     +1377     

see 67 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 16, 2024
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexanderguzhva
Copy link
Collaborator Author

superceded by #663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants